Raft should not initialize if db is misconfigured. Fixes #1973

controller/controller.go

@@ -515,21 +515,34 @@ func (c *Controller) routerDispatchCallback(evt *event.ClusterEvent) {
 	}
 }
 
-func (c *Controller) TryInitializeRaftFromBoltDb() error {
+func (c *Controller) getMigrationDb() (*string, error) {
 	val, found := c.config.src["db"]
 	if !found {
-		return nil
+		return nil, nil
 	}
 
 	path := fmt.Sprintf("%v", val)
 	if _, err := os.Stat(path); err != nil {
 		if os.IsNotExist(err) {
-			return errors.Wrapf(err, "source db not found at [%v], either remove 'db' config setting or fix path ", path)
+			return nil, errors.Wrapf(err, "source db not found at [%v], either remove 'db' config setting or fix path ", path)
 		}
-		return errors.Wrapf(err, "invalid db path [%v]", path)
+		return nil, errors.Wrapf(err, "invalid db path [%v]", path)
 	}
 
-	return c.InitializeRaftFromBoltDb(path)
+	return &path, nil
+}
+
+func (c *Controller) ValidateMigrationEnvironment() error {
+	_, err := c.getMigrationDb()
+	return err
+}
+
+func (c *Controller) TryInitializeRaftFromBoltDb() error {
+	path, err := c.getMigrationDb()
+	if err != nil || path == nil {
+		return err
+	}
+	return c.InitializeRaftFromBoltDb(*path)
 }
 
 func (c *Controller) InitializeRaftFromBoltDb(sourceDbPath string) error {

controller/raft/raft.go

@@ -657,6 +657,10 @@ func (self *Controller) Bootstrap() error {
 		logrus.Info("raft already bootstrapped")
 		self.bootstrapped.Store(true)
 	} else {
+		if err := self.migrationMgr.ValidateMigrationEnvironment(); err != nil {
+			return err
+		}
+
 		if err := self.addConfiguredBootstrapMembers(); err != nil {
 			return err
 		}
@@ -834,6 +838,7 @@ func (self *Controller) addEventsHandlers() {
 }
 
 type MigrationManager interface {
+	ValidateMigrationEnvironment() error
 	TryInitializeRaftFromBoltDb() error
 	InitializeRaftFromBoltDb(srcDb string) error
 }