Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect default ports on docker .env file #986

Closed
gooseleggs opened this issue Feb 2, 2023 · 3 comments · Fixed by #1107
Closed

Incorrect default ports on docker .env file #986

gooseleggs opened this issue Feb 2, 2023 · 3 comments · Fixed by #1107
Assignees

Comments

@gooseleggs
Copy link
Contributor

gooseleggs commented Feb 2, 2023

The docker .env file, located here: https://github.com/openziti/ziti/blob/release-next/quickstart/docker/.env

is not defining default ports for the services. Therefore, when the user does not define the variable (ie hashes it out for example), then the port reverts to the defined default which is not what is in the .env file.

Reference: https://openziti.discourse.group/t/problems-with-docker-compose-setup-and-minecraft-example/1018

The docker-compose.yml file defines the ports to be used if the environment variables are not defined. The .env file should mimic this by default.

Case in point ZITI_EDGE_ROUTER_PORT should be defined as 3022, and not 8442.

@arunbingari
Copy link

I would like to work on this ! Please assign me !

@dovholuknf
Copy link
Member

@gberl002 - you have some changes in flight that might address this, right? @arunbingari -- if @gberl002 doesn't already have this accounted for, we'll let you know. thanks for volunteering!

@gberl002
Copy link
Contributor

@arunbingari This one is also being fixed by my quickstart cleanup branch. I haven't tied it to the branch yet, sorry about that.

I generally make a run through the issues after a PR is up, as some bugs get inadvertently fixed during other changes/fixes. I ran through the issues list just now, and I've updated any issues being fixed by my cleanup to be assigned to me and tied to my branch. So, if you want to look through the issues for another bug, anything not already assigned should be free to work on.

@gberl002 gberl002 self-assigned this Apr 26, 2023
@gberl002 gberl002 linked a pull request May 1, 2023 that will close this issue
plorenz pushed a commit that referenced this issue Sep 28, 2023
use centralized logic to add signers for cache load and live def
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants