Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup a docker-compose override file. #843

Merged
merged 5 commits into from
Jul 15, 2016
Merged

Setup a docker-compose override file. #843

merged 5 commits into from
Jul 15, 2016

Conversation

tecnobrat
Copy link
Contributor

This moves the "secrets" into a docker-compose override. This allows the docker-compose file to be committed, and we have an example override.

Also adds the new bootstrap env vars so that you can launch cog without any configuration at all.

- COG_TRIGGER_URL_HOST=192.168.99.100
- COG_TRIGGER_URL_PORT=4001
- COG_SERVICE_URL_HOST=192.168.99.100
- COG_SERVICE_URL_PORT=4002
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps these ports can be in the base docker-compose

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think they make sense in the base because they match the defaults from Cog.

@imbriaco
Copy link
Member

imbriaco commented Jul 8, 2016

Thanks for the PR, I like the direction!

One behavior that we have with the existing docker-compose.example.yml that I'd like to keep is that we only require users to set a couple of environment variables if they just want to kick the tires with a test environment. I think we can keep that behavior while still adding the override file which I quite like by making the defaults for SLACK_API_TOKEN and the *_URL_HOST variables use environment variable interpolation in the override file for their defaults.

I also think we should use default values for the COG_BOOTSTRAP_* variables that mirror what Cog does by default as much as possible. Perhaps:

COG_BOOTSTRAP_USERNAME=admin
COG_BOOTSTRAP_PASSWORD=changeme
COG_BOOTSTRAP_EMAIL_ADDRESS=cog@localhost
COG_BOOTSTRAP_FIRST_NAME=Cog
COG_BOOTSTRAP_LAST_NAME=Administrator

What do you think?

@tecnobrat
Copy link
Contributor Author

@imbriaco made those changes.

Also tweaked the hostnames to be cog and postgres instead of aliasing to localhost, which has the potential to cause some significant issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants