-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup a docker-compose override file. #843
Conversation
- COG_TRIGGER_URL_HOST=192.168.99.100 | ||
- COG_TRIGGER_URL_PORT=4001 | ||
- COG_SERVICE_URL_HOST=192.168.99.100 | ||
- COG_SERVICE_URL_PORT=4002 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps these ports can be in the base docker-compose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think they make sense in the base because they match the defaults from Cog.
Thanks for the PR, I like the direction! One behavior that we have with the existing I also think we should use default values for the
What do you think? |
@imbriaco made those changes. Also tweaked the hostnames to be |
This moves the "secrets" into a docker-compose override. This allows the docker-compose file to be committed, and we have an example override.
Also adds the new bootstrap env vars so that you can launch cog without any configuration at all.