Add resourcequotas and limitrange components. #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesheta
added
the
size/M
tumido
requested changes
Mar 26, 2021
cluster-scope/components/resourcequotas/bronze/resourcequotas.yaml
Outdated
Show resolved
Hide resolved
HumairAK
force-pushed
the
resource_quotas
branch
from
2b2208d
to
8eb248c
Compare
|
Thoughts on the actual resource values for each tier? |
4n4nd
reviewed
Mar 26, 2021
|
@HumairAK does it make sense to look at the current resource utilization of the cluster to help determine reasonable quota values? |
HumairAK
force-pushed
the
resource_quotas
branch
from
8eb248c
to
57fac27
Compare
|
I've updated the values based on discussions in the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tumido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
This was referenced Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #438
The
resourcequotasaren't included in any of the namespaces yet, this is one way we can go about this. The idea is to include these like we do every other component within the cluster-scope/base/namespaces.We don't have to use tiers if there are good arguments against it, this is a suggestion.
I just willy nilly picked amounts for each tier and
limitrange. We can discuss what amounts are reasonable.WDYT?