Skip to content
This repository has been archived by the owner on Sep 29, 2021. It is now read-only.

chore: Cleanup ArgoCD app names #101

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

tumido
Copy link
Member

@tumido tumido commented Mar 12, 2021

Part of: #73

Make the app names in cluster-management unique by suffixes.

@sesheta sesheta requested review from 4n4nd and naved001 March 12, 2021 12:47
@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 12, 2021
@sesheta sesheta added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2021
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
@HumairAK
Copy link
Member

/hold
let's merge this on monday since it may require us to monitor closely as it will delete + recreate certain apps

@sesheta sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2021
@sesheta
Copy link
Member

sesheta commented Mar 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2021
@tumido
Copy link
Member Author

tumido commented Mar 22, 2021

@HumairAK wdyt, can we unhold?
/cc @4n4nd

@HumairAK
Copy link
Member

/unhold

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2021
@HumairAK HumairAK merged commit 5cd6c62 into operate-first:main Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants