-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concern - ArgoCD application name conflicts #63
Comments
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. /close |
@sesheta: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Aggregating many application across multiple repositories and deploying to multiple clusters increases a risk of an application being named the same. On the other hand the nature of the OCP platform itself limits us to unique application names only, because all the
Application
resources land in the same namespace.The situation is even more unfortunate in cases when different app-of-apps would try syncing different application specs with the same name. ArgoCD would end up with 2 competing apps syncing "the same" resource.
The possibility of this happening grows with the amount of clusters and teams onboarded.
Proposed solution
Use
namePreffix
ornameSuffix
inkustomization.yaml
for different sections ofargocd-apps
Similar to this PR: operate-first/argocd-apps#101
This works only for well behaving apps, since it's part of the manifests
Doesn't work for conflicts between
app-of-apps
- 2 different app of apps can still apply a resource with the same nameUse
Applicaton
resource parametersWorks exceptionally well for app-of-apps, since it operates on app of apps resource spec level: always makes all applications deployed via an app of apps to follow the naming scheme.
Independent from the manifests deployed by app of apps
https://argoproj.github.io/argo-cd/user-guide/kustomize/#kustomize
Result of a discussion on this issue will be submitted as an ADR.
The text was updated successfully, but these errors were encountered: