Skip to content
This repository has been archived by the owner on Sep 29, 2021. It is now read-only.

Add cluster group management app #36

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

HumairAK
Copy link
Member

@HumairAK HumairAK commented Jan 20, 2021

This PR will:

  • add the cluster management application, to automate cluster resource deployments
  • add project app to deploy argocd projects

This PR should not be applied until the pr here is applied. The reason being is ArgoCD can't decrypt the encrypted groups yet in the cluster-scope app.

@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 20, 2021
@HumairAK HumairAK added blocked and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 20, 2021
@HumairAK HumairAK requested review from 4n4nd and tumido January 20, 2021 02:09
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few notes inline. The onboarding docs look good to me. 👍

overlays/moc/cluster-management/argocd-projects.yaml Outdated Show resolved Hide resolved
@tumido
Copy link
Member

tumido commented Jan 20, 2021

@HumairAK can we extract the doc from this PR and rather put it at the /support repo? It make more sense to me to keep it there. I'd also prefer seeing the docs in place rather soon and not having them blocked by the moc PR.

@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 20, 2021
@HumairAK
Copy link
Member Author

HumairAK commented Jan 20, 2021

Docs were removed in this pr, they are added here here

@HumairAK HumairAK changed the title Add cluster group management app, clean up onboarding docs, move project group Add cluster group management app Jan 20, 2021
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2021
@HumairAK HumairAK removed the blocked label Jan 21, 2021
@sesheta
Copy link
Member

sesheta commented Jan 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 4n4nd, tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK HumairAK merged commit 2b7d291 into operate-first:main Jan 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants