-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few notes inline. The onboarding docs look good to me. 👍
@HumairAK can we extract the doc from this PR and rather put it at the |
87bb178
to
8cc2720
Compare
8cc2720
to
74770f3
Compare
Docs were removed in this pr, they are added here here |
74770f3
to
13e1740
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 4n4nd, tumido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR will:
This PR should not be applied until the pr here is applied. The reason being is ArgoCD can't decrypt the encrypted groups yet in the cluster-scope app.