Skip to content
This repository has been archived by the owner on Sep 29, 2021. It is now read-only.

Onboard mesh-for-data #40

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Onboard mesh-for-data #40

merged 1 commit into from
Jan 21, 2021

Conversation

HumairAK
Copy link
Member

@HumairAK HumairAK commented Jan 20, 2021 •
edited
Loading

Onboarding mesh-for-data, as per request
Let's have this follow #36

@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 20, 2021
@HumairAK
Copy link
Member Author

HumairAK commented Jan 20, 2021 •
edited
Loading

/hold
This may need a rebase once #36 is merged.

@sesheta sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2021
@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2021
@sefkhet-abwy sefkhet-abwy bot added the do-not-merge/needs-rebase The head of the PR needs to be rebased. label Jan 21, 2021
@sesheta sesheta added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 21, 2021
@HumairAK
Copy link
Member Author

rebasing

@sesheta sesheta removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 21, 2021
@sefkhet-abwy sefkhet-abwy bot removed the do-not-merge/needs-rebase The head of the PR needs to be rebased. label Jan 21, 2021
@sesheta
Copy link
Member

sesheta commented Jan 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 4n4nd, hemajv, tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [4n4nd,hemajv,tumido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK
Copy link
Member Author

/unhold

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2021
@HumairAK HumairAK merged commit fdf7c7c into operate-first:main Jan 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hemajv hemajv hemajv approved these changes

@tumido tumido tumido approved these changes

@4n4nd 4n4nd 4n4nd approved these changes

@martinpovolny martinpovolny Awaiting requested review from martinpovolny

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@HumairAK @sesheta @hemajv @tumido @4n4nd