fix: Change installing helm from installer to extracting binaries #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesheta
added
the
size/XS
tumido
requested changes
Oct 27, 2021
There was a problem hiding this comment.
FTR get_helm.sh script is not broken per-se, but it got changed - version pinning requires DESIRED_VERSION variable. That means following patch would fix this:
# Install Helm
curl -fsSL -o get_helm.sh https://raw.githubusercontent.com/helm/helm/$HELM_VERSION/scripts/get-helm-3 && \
export DESIRED_VERSION=$HELM_VERSION && \
chmod 700 get_helm.sh && ./get_helm.sh && \But instead of fixing it this way I believe it's reasonable to just omit the installer script and download the binary directly ourselves.
Proposed patch by @mimotej can be simplified though.
Signed-off-by: Michal Drla <mdrla@redhat.com>
mimotej
force-pushed
the
fix-helm-installer
branch
from
e0af2be
to
6cd6e1a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tumido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues and Dependencies
…
This introduces a breaking change
This Pull Request implements
The get_helm.sh script seems to be currently broken, so let's move from installing the helm through installer to getting binaries directly from github release page.
Description
/cc @tumido