-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kustomize-hash-annotator to toolbox image #80
Conversation
hmm did this work for you when you tried using it with the toolbox? I get the following using the example in their readme:
(Not sure what's going on with the bash errors, but I don't think it's related). |
c453511
to
bbdd6c2
Compare
@HumairAK I just updated this to use the environment variable for the kustomize plugin path rather than the hardcoded path. I'm not sure that that will change anything for you, but it's definitely better practice. I admittedly did not try using this with toolbox - I was primarily focused on the use case of getting the aicoe-ci tests passing. Does ksops work for you? I'm trying to understand what kustomize plugin path is used. |
@accorvin I was able to get it working by renaming the
I think the file at: |
This adds the kustomize-hash-annotator [1] kustomize plugin to the toolbox image. This plugin allows for dynamically annotating an object with the hash of the contents of a configmap or secret, allowing for, among other things, automatic rollouts of deployments based on updates to configmaps and secrets. [1]: https://github.com/pcjun97/kustomize-hash-annotator
bbdd6c2
to
dd13b98
Compare
@HumairAK I got this fixed in the upstream hashannotator plugin code so the file name should be correct now. |
/lgtm Thanks @accorvin !! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related Issues and Dependencies
…
This introduces a breaking change
This Pull Request implements
Add the kustomize-hash-annotator kustomize plugin
Description
This adds the kustomize-hash-annotator 1 kustomize plugin to the
toolbox image. This plugin allows for dynamically annotating an object
with the hash of the contents of a configmap or secret, allowing for,
among other things, automatic rollouts of deployments based on updates
to configmaps and secrets.