This repository has been archived by the owner on Jul 30, 2021. It is now read-only.
[scripts] Update semver regex #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
SamiSousa
force-pushed
the
update-semver
branch
from
945e96c
to
5768dd2
Compare
|
This change is required for CI to work with operators with versions such as #280 : https://github.com/operator-framework/community-operators/pull/280/files#diff-e2003439d400d84637f240ca92eeb43bR213 |
estroz
reviewed
Apr 26, 2019
scripts/ci/operators-env
Outdated
|
|
||
| # Source: https://github.com/k-bx/python-semver | ||
| # Note: This regex is slightly modified from the source | ||
| SEMVER_REGEX="((0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)(\-(0|[1-9A-Za-z-][0-9A-Za-z-]*(\.0|[1-9A-Za-z-][0-9A-Za-z-]*)*))?(\+([0-9A-Za-z-]+(\.[0-9A-Za-z-]+)*))?)" |
There was a problem hiding this comment.
You can put this in scripts/lib/file, and add
for f in "$(cd "$(dirname ${BASH_SOURCE[0]})/.." && pwd)"/lib/*; do
. "$f"
doneabove.
There was a problem hiding this comment.
That sounds perfect!
- Update semver regex to better match more valid semver - Include SEMVER_REGEX env variable in scripts/lib/file Previously, our regex was an approximation of what the semver standard supports. This regex should more precisely match valid semvers.
SamiSousa
force-pushed
the
update-semver
branch
from
5768dd2
to
35cf09a
Compare
|
@estroz Updated based on your comment, PTAL! |
|
/lgtm |
estroz
approved these changes
Apr 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our regex was an approximation of what the semver
standard supports. This regex should more precisely match valid semvers.