Vendor helm, since it is used for templating manifests. #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinned to a recent commit including a change that resolves the arbitrary reordering of multi-document manifests. See: helm/helm@4d8160e#diff-1b5cea5b40418f5f5929d3b62034886dR107
openshift-ci-robot
added
the
size/XXL
|
/lgtm /retest doesn't have to be this PR, but we should update the requirements in the release doc to indicate that helm is no longer a prereq 😄 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
I'm ten steps ahead of you -- the doc never mentioned that helm was required. 🥇 |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinned to a recent commit including a change that resolves the
arbitrary reordering of multi-document manifests. See:
helm/helm@4d8160e#diff-1b5cea5b40418f5f5929d3b62034886dR107
This is related to the earlier PR #1228 -- I didn't notice at the time that the document reordering was arbitrary.