chore(deps): bump to kube 1.17.3 #1370

anik120 · 2020-03-13T19:05:01Z

Description of the change:

Updates kube dependencies to 1.17.3.
Removes dependency on k8s.io/kubernetes my manually
vendoring 1.17 version of it inside pkg/lib/ as a stop gap
measure till other alternatives to rbac authorizer and any
other parts of k8s.io/kubernetes used in olm is found.
Regenerate API types in accordance with openapi3
specification

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation
Sufficient unit test coverage
Sufficient end-to-end test coverage
Docs updated or added to /docs
Commit messages sensible and descriptive

anik120 · 2020-03-13T19:13:26Z

/hold

Bowenislandsong

Thanks for doing this. I have 2 questions:

Why are we no longer using replace to pin kube versions like what openshift is doing?
Would you consider using the solution here: 'unknown revision v0.0.0' errors, seemingly due to 'require k8s.io/foo v0.0.0' kubernetes/kubernetes#79384?

anik120 · 2020-03-16T19:09:56Z

/hold-cancel
@Bowenislandsong please refer operator-framework/operator-registry#201
Specifically,

Since k8s repos now offer a "native" way to pin versions k8s 1.16.7 maps to a go.mod version of v0.16.7, we can achieve the pinning to a particular kubernetes version without using the replace directive.

ecordell · 2020-03-16T19:20:13Z

go.mod

 	sigs.k8s.io/controller-tools v0.2.4
 )

+// NOTE: k8s.io/Kubernetes v1.17 is currently vendored by hand in pkg/lib and should be
+// bumped along with other kube modules unitll dependency on k8s.io/Kubernetes is removed
+
 replace (
 	github.com/docker/docker => github.com/moby/moby v0.7.3-0.20190826074503-38ab9da00309 // Required by Helm
 	github.com/openshift/api => github.com/openshift/api v3.9.1-0.20190924102528-32369d4db2ad+incompatible


Can this dependency be fixed as well?

@ecordell #1370 (comment)

ecordell · 2020-03-16T19:20:44Z

go.mod

-	k8s.io/sample-apiserver => k8s.io/sample-apiserver v0.0.0-20190918161442-d4c9c65c82af
-	k8s.io/sample-cli-plugin => k8s.io/sample-cli-plugin v0.0.0-20190918162410-e45c26d066f2
-	k8s.io/sample-controller => k8s.io/sample-controller v0.0.0-20190918161628-92eb3cb7496c
+	sigs.k8s.io/structured-merge-diff => sigs.k8s.io/structured-merge-diff v1.0.1-0.20191108220359-b1b620dd3f06


this doesn't work if we just require 1.0.1?

@ecordell unfortunately, this is the version that k8s.io/apiserver needs, but there is another module that is changing the version of sigs.k8s.io/structured-merge-diff to a version that is breaking for v0.17.3 of k8s.io/apiserver. So had to pin this version to appease all modules.

Bowenislandsong

Thanks for the update. We would want this changed to master or whatever openshift/oc is using as well.

Bowenislandsong · 2020-03-16T20:26:47Z

go.mod

@@ -14,8 +15,8 @@ require (
 	github.com/mitchellh/hashstructure v1.0.0
 	github.com/openshift/api v3.9.1-0.20190924102528-32369d4db2ad+incompatible


you might wan to fix this!

@Bowenislandsong thanks for noticing it! I've changed it to the tag being used by openshift/oc currently.

anik120 · 2020-03-16T20:33:00Z

/retest unit
/retest verify

anik120 · 2020-03-17T12:59:08Z

/hold cancel
/retest

anik120 · 2020-03-17T13:29:05Z

/test unit

anik120 · 2020-03-17T14:55:43Z

/test e2e-gcp-upgrade

anik120 · 2020-03-17T17:46:46Z

/test e2e-gcp-upgrade

anik120 · 2020-03-19T15:29:46Z

Updated PR to include a commit that updates API types in accordance with updated openapi specifications.

References:
What are the annotations for in the commit?
How can I verify if the annotations are correct?
Why are the variable names being changed in the commit?

LouisPlisso · 2020-03-19T17:33:38Z

Thanks for doing this: hopefully soon the replace usage will be rare and we'll be able to import without problems :)

anik120 · 2020-03-19T21:21:38Z

/test e2e-gcp
/test e2e-aws-console-olm

anik120 · 2020-03-19T23:26:02Z

/test e2e-gcp
/test e2e-aws-console-olm

anik120 · 2020-03-20T00:58:57Z

/retest

* Updates kube dependencies to 1.17.3. * Also removes dependency on k8s.io/kubernetes my manually vendoring 1.17 version of it inside pkg/lib/ as a stop gap measure till other alternatives to rbac authorizer and any other parts of k8s.io/kubernetes used in olm is found.

In kube 1.17, the openapi structural schema validation was updated to validate CRDs according to the documented API semantics of x-kubernetes-list-type and x-kubernetes-map-type atomic to reject non-atomic sub-types. This PR updates the API types to follow the specification.

openshift-bot · 2020-03-24T01:30:10Z

/retest