Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency on github.com/openshift/api #1241

Closed
wants to merge 1 commit into from

Conversation

grdryn
Copy link

@grdryn grdryn commented Jan 21, 2020

It looks like the openshift/api project deleted all of their tags, so
now the following error is thrown any time we run e.g. a go mod tidy
in any project that depends on it:

go: github.com/openshift/api@v3.9.1-0.20190924102528-32369d4db2ad+incompatible: invalid pseudo-version: preceding tag (v3.9.0) not found

For this change, all I did was remove the entries in "require" and
"replace" in the go.mod, manually added the new "replace" and ran go mod tidy.

See openshift/api#456 for more info on the
issue.


Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot
Copy link
Collaborator

Hi @grdryn. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 21, 2020
@exdx
Copy link
Member

exdx commented Jan 21, 2020

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 21, 2020
@ecordell
Copy link
Member

@grdryn Thanks for the PR - could you run make vendor as well, to vendor the changes you've made here? Then we can validate them.

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 23, 2020
@grdryn
Copy link
Author

grdryn commented Jan 23, 2020

@ecordell I've updated that now, thanks!

@ecordell
Copy link
Member

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, grdryn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 24, 2020
@openshift-ci-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 24, 2020
@ecordell
Copy link
Member

@grdryn what changed when you force pushed? I don't see a difference

@grdryn
Copy link
Author

grdryn commented Jan 24, 2020

@ecordell it was just a rebase because of some conflicts in the generated files (go.mod and vendor/modules.txt).

I'm not familiar enough with the failing e2e tests to know if they're failing because of my changes, are they?

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2020
@njhale
Copy link
Member

njhale commented Feb 19, 2020

@grdryn if you could rebase when you get the chance, I'll circle back for a swift review to get this in.

It looks like the openshift/api project deleted all of their tags, so
now the following error is thrown any time we run e.g. a `go mod tidy`
in any project that depends on it:

```
go: github.com/openshift/api@v3.9.1-0.20190924102528-32369d4db2ad+incompatible: invalid pseudo-version: preceding tag (v3.9.0) not found
```

For this change, all I did was remove the entries in "require" and
"replace" in the go.mod, manually added the new "replace" and ran `make vendor`.

See openshift/api#456 for more info on the
issue.
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 19, 2020
@grdryn
Copy link
Author

grdryn commented Feb 19, 2020

@njhale I've rebased & bumped the commit of openshift/api (I don't really know what it should be set to, so I've just used the latest commit on master).

@grdryn
Copy link
Author

grdryn commented Feb 19, 2020

/retest

@grdryn
Copy link
Author

grdryn commented Feb 20, 2020

/test unit

^Unit tests seem to work fine for me locally 🤷‍♂️

@openshift-ci-robot
Copy link
Collaborator

@grdryn: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/unit 14919df link /test unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@grdryn
Copy link
Author

grdryn commented Feb 24, 2020

/test unit

@ecordell
Copy link
Member

This was resolved in #1370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants