Adjust CSV status descriptors for Vault to reflect new status block #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example status block:
```
status:
clientPort: 8200
initialized: true
nodes:
active: example-vault-1395307387-682n0
available:
- example-vault-1395307387-682n0
- example-vault-1395307387-w7smw
sealed: null
standby:
- example-vault-1395307387-w7smw
updated:
- example-vault-1395307387-682n0
- example-vault-1395307387-w7smw
serviceName: example-vault
```
ecordell
requested changes
Nov 3, 2017
| path: serviceName | ||
| x-descriptors: | ||
| - 'urn:alm:descriptor:io.kubernetes:Service' | ||
| - description: The port at which the Vault cluster is running under the service. |
There was a problem hiding this comment.
doesn't this need x-descriptors?
There was a problem hiding this comment.
Nope; they are optional and not necessary for simple displays of information. We should probably add some later, but for now, not necessary
njhale
pushed a commit
to njhale/operator-lifecycle-manager
that referenced
this pull request
Sep 10, 2018
…horr/ALM-248/vault-csv Adjust CSV status descriptors for Vault to reflect new status block
ecordell
pushed a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
…horr/ALM-248/vault-csv Adjust CSV status descriptors for Vault to reflect new status block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example status block: