-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1859493: fix(resolver): Exclude all installed packages in dependency search #1664
Bug 1859493: fix(resolver): Exclude all installed packages in dependency search #1664
Conversation
@dinhxuanvu: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest I'm suspicious that the test that was modified is failing in the upstream and downstream e2es, but I don't see anything obviously wrong. |
1. Fix validate CRD compatibility Should only run against served versions instead the non-served versions (! operator error) 2. Clean up the deprecated CRD versions test: Using standup catsrc upgrade and get rid of unnecessary subscription deletion. Signed-off-by: Vu Dinh <vdinh@redhat.com>
Signed-off-by: Vu Dinh <vdinh@redhat.com>
Currently, resolver only excludes one installed package at a time during dependency search. However, this is not enough as there is a corner case where there are two operators that are requiring the same CRD(s). As a result, resolver only excludes one package but not the other(s). Now, the list of installed packages in the same namespace will be added to list of packages that are not considered during dependency search. Signed-off-by: Vu Dinh <vdinh@redhat.com>
1903afb
to
f0e6afb
Compare
/retest |
9ad78cf
to
689fde4
Compare
@dinhxuanvu: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dinhxuanvu: This pull request references Bugzilla bug 1859493, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
1 similar comment
/retest |
Signed-off-by: Vu Dinh <vdinh@redhat.com>
689fde4
to
3c0fcf1
Compare
/retest |
/bugzilla refresh |
@cuppett: This pull request references Bugzilla bug 1859493, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dinhxuanvu: All pull requests linked via external trackers have merged: operator-framework/operator-lifecycle-manager#1664. Bugzilla bug 1859493 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs