Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1859493: fix(resolver): Exclude all installed packages in dependency search #1664

Merged
merged 4 commits into from Jul 22, 2020
Merged

Bug 1859493: fix(resolver): Exclude all installed packages in dependency search #1664

merged 4 commits into from Jul 22, 2020

Conversation

dinhxuanvu
Copy link
Member

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot
Copy link
Collaborator

@dinhxuanvu: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[4.5] fix(resolver): Exclude all installed packages in dependency search

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Member

/retest

I'm suspicious that the test that was modified is failing in the upstream and downstream e2es, but I don't see anything obviously wrong.

@dinhxuanvu
Fix validate CRD compatibility check and deprecated CRD test case
54b3c81 
1. Fix validate CRD compatibility
Should only run against served versions instead the non-served
versions (! operator error)
2. Clean up the deprecated CRD versions test:
Using standup catsrc upgrade and get rid of unnecessary subscription
deletion.

Signed-off-by: Vu Dinh <vdinh@redhat.com>
@dinhxuanvu
Fix UpdateSingleExistingCRDOwner test case
9a138ed 
Signed-off-by: Vu Dinh <vdinh@redhat.com>
@dinhxuanvu
fix(resolver): Exclude all installed packages in dependency search
1b48829 
Currently, resolver only excludes one installed package at a time during
dependency search. However, this is not enough as there is a corner case
where there are two operators that are requiring the same CRD(s). As a
result, resolver only excludes one package but not the other(s).

Now, the list of installed packages in the same namespace will be added
to list of packages that are not considered during dependency search.

Signed-off-by: Vu Dinh <vdinh@redhat.com>
@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu dinhxuanvu force-pushed the ocs-lib-fix-4.5 branch 2 times, most recently from 9ad78cf to 689fde4 Compare July 22, 2020 09:29
@dinhxuanvu dinhxuanvu changed the title [4.5] fix(resolver): Exclude all installed packages in dependency search Bug 1859493 fix(resolver): Exclude all installed packages in dependency search Jul 22, 2020
@openshift-ci-robot
Copy link
Collaborator

@dinhxuanvu: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug 1859493 fix(resolver): Exclude all installed packages in dependency search

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dinhxuanvu dinhxuanvu changed the title Bug 1859493 fix(resolver): Exclude all installed packages in dependency search Bug 1859493: fix(resolver): Exclude all installed packages in dependency search Jul 22, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 22, 2020
@openshift-ci-robot
Copy link
Collaborator

@dinhxuanvu: This pull request references Bugzilla bug 1859493, which is invalid:

  • expected dependent Bugzilla bug 1857424 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1859493: fix(resolver): Exclude all installed packages in dependency search

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dinhxuanvu
Copy link
Member Author

/retest

1 similar comment
@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Update the e2e test case
3c0fcf1 
Signed-off-by: Vu Dinh <vdinh@redhat.com>
@dinhxuanvu
Copy link
Member Author

/retest

@cuppett
Copy link

cuppett commented Jul 22, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 22, 2020
@openshift-ci-robot
Copy link
Collaborator

@cuppett: This pull request references Bugzilla bug 1859493, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1857424 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1857424 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Member

/approve
/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit 9864f5d into operator-framework:release-4.5 Jul 22, 2020
@openshift-ci-robot
Copy link
Collaborator

@dinhxuanvu: All pull requests linked via external trackers have merged: operator-framework/operator-lifecycle-manager#1664. Bugzilla bug 1859493 has been moved to the MODIFIED state.

In response to this:

Bug 1859493: fix(resolver): Exclude all installed packages in dependency search

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benluddy benluddy Awaiting requested review from benluddy

@njhale njhale Awaiting requested review from njhale

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dinhxuanvu @openshift-ci-robot @ecordell @cuppett @sdodson @openshift-merge-robot