Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1916021: Fix infinite loop when a CSV replacement chain contains a cycle. #1966

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Bug 1916021: Fix infinite loop when a CSV replacement chain contains a cycle. #1966

merged 1 commit into from
Jan 20, 2021

Conversation

benluddy
Copy link
Contributor

No description provided.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2021
@benluddy benluddy changed the title Fix infinite loop when a CSV replacement chain contains a cycle. Bug 1916021: Fix infinite loop when a CSV replacement chain contains a cycle. Jan 19, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 19, 2021
@openshift-ci-robot
Copy link
Collaborator

@benluddy: This pull request references Bugzilla bug 1916021, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1916021: Fix infinite loop when a CSV replacement chain contains a cycle.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@benluddy
Copy link
Contributor Author

/cherry-pick release-4.6

@openshift-cherrypick-robot
Copy link

@benluddy: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@benluddy
Fix infinite loop when a CSV replacement chain contains a cycle.
8e568ba 
Signed-off-by: Ben Luddy <bluddy@redhat.com>
@benluddy
Copy link
Contributor Author

/retest

@benluddy
Copy link
Contributor Author

@benluddy: The following test failed, say /retest to rerun all failed tests:
Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm 8e568ba link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard.

It looks like openshift/console#7874 is in progress to resolve this test failure.

@hasbro17
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b925df3 into operator-framework:master Jan 20, 2021
@openshift-ci-robot
Copy link
Collaborator

@benluddy: All pull requests linked via external trackers have merged:

Bugzilla bug 1916021 has been moved to the MODIFIED state.

In response to this:

Bug 1916021: Fix infinite loop when a CSV replacement chain contains a cycle.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 20, 2021
Merged
@openshift-cherrypick-robot
Copy link

@benluddy: new pull request created: #1970

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasbro17 hasbro17 hasbro17 left review comments

@anik120 anik120 Awaiting requested review from anik120

@ecordell ecordell Awaiting requested review from ecordell

Assignees

@hasbro17 hasbro17

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@benluddy @openshift-ci-robot @openshift-cherrypick-robot @hasbro17 @openshift-bot @openshift-merge-robot