Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.5] Bug 1928263: Fix zero-delay resyncs for certain registry update policies. #2006

Merged
merged 1 commit into from Feb 18, 2021
Merged

[release-4.5] Bug 1928263: Fix zero-delay resyncs for certain registry update policies. #2006

merged 1 commit into from Feb 18, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1989

/assign exdx

@benluddy
Fix zero-delay resyncs for certain registry update policies.
1859587 
If the registry update polling interval is greater than and a multiple
of the operator's default resync period (15m), and there are fewer
than 15 minutes remaining until the next poll is due, the
catalog-operator will continuously resync its associated CatalogSource
until the next poll time is reached. This is not beneficial to update
polling and can generate excessive load that negatively impacts useful
work on the cluster.

Signed-off-by: Ben Luddy <bluddy@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 12, 2021
Merged
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: Bugzilla bug 1922919 has been cloned as Bugzilla bug 1928263. Retitling PR to link against new bug.
/retitle [release-4.5] [release-4.6] Bug 1928263: Fix zero-delay resyncs for certain registry update policies.

In response to this:

[release-4.5] [release-4.6] Bug 1922919: Fix zero-delay resyncs for certain registry update policies.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] [release-4.6] Bug 1922919: Fix zero-delay resyncs for certain registry update policies. [release-4.5] [release-4.6] Bug 1928263: Fix zero-delay resyncs for certain registry update policies. Feb 12, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Feb 12, 2021
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1928263, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1922919 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1922919 targets the "4.6.z" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

[release-4.5] [release-4.6] Bug 1928263: Fix zero-delay resyncs for certain registry update policies.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 12, 2021
@exdx exdx changed the title [release-4.5] [release-4.6] Bug 1928263: Fix zero-delay resyncs for certain registry update policies. [release-4.5] Bug 1928263: Fix zero-delay resyncs for certain registry update policies. Feb 12, 2021
@kevinrizza
Copy link
Member

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2021
@dinhxuanvu
Copy link
Member

/test e2e-aws-olm

dinhxuanvu
dinhxuanvu approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, kevinrizza, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@derekwaynecarr
Copy link

(Patch Manager) approving as it met criteria.

@derekwaynecarr derekwaynecarr added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 17, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 83b6bba into operator-framework:release-4.5 Feb 18, 2021
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1928263 has been moved to the MODIFIED state.

In response to this:

[release-4.5] Bug 1928263: Fix zero-delay resyncs for certain registry update policies.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu dinhxuanvu approved these changes

@awgreene awgreene Awaiting requested review from awgreene

@benluddy benluddy Awaiting requested review from benluddy

Assignees

@dinhxuanvu dinhxuanvu

@exdx exdx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@openshift-cherrypick-robot @openshift-ci-robot @kevinrizza @dinhxuanvu @derekwaynecarr @openshift-bot @openshift-merge-robot @exdx @benluddy