wait for catalogsource pod deletion

[akihikokuroda]

Signed-off-by: akihikokuroda akihikokuroda2020@gmail.com

Description of the change:
Add code that wait for deletion of the catalogsource pod in the CatalogSourceCleanupFunc.

Motivation for the change:
Possible fix for issue #2440

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /doc
• Commit messages sensible and descriptive

[openshift-ci]

Hi @akihikokuroda. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[timflannagan]

Thanks for trying to tackling this and help cut down on some of the e2e tests that have been failing recently. I had a couple of quick comments/suggestions/etc. inline. I haven't poked around the testing packages to see whether this is an issue with test pollution, e.g. another, unrelated catalogsource test pod is influencing this failing assertion, but introducing additional safeguards should be sufficient. I'm hoping to take a better look later today too.

/ok-to-test

[timflannagan]

I think these changes look reasonable to me, so I'll preemptively tag it while we wait for e2e run - we'll have to chase down an approver next week before it can merge.

/lgtm

[akihikokuroda]

How can I rerun the failing test?

[timflannagan]

@akihikokuroda I'm not entirely sure what kind of repository permissions you would need to restart checks unfortunately - I'm going manually recycle them as the workflows in this PR have been renamed.

[timflannagan]

/lgtm

[awgreene]

Great work.
/approve

[ankitathomas]

/retest

[timflannagan]

@akihikokuroda Can you rebase this when you get a chance? I think this is ready to go but I don't want to tag this PR with a lgtm and have the openshift-bot spam retest commands in the meantime.

[timflannagan]

Thanks!

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akihikokuroda, awgreene, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [awgreene,timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment