Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean-up: add dependabot #3226

Merged

Conversation

perdasilva
Copy link
Collaborator

Description of the change:
Adds dependabot configuration to .github that will submit update PRs on a weekly basis to update go mod dependencies as well as github actions

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@tmshort
Copy link
Contributor

tmshort commented May 6, 2024

I thought we already had this? e.g.
#3205
Is this just configuration?

@itroyano
Copy link

itroyano commented May 6, 2024

That's a bit confusing @tmshort because I don't see a dependabot.yml in this repo. I see it in OLM v1 repo though.

@perdasilva
Copy link
Collaborator Author

I think only security updates are enabled. I figured it would be good to have a configuration file anyway to keep it all as code.

@joelanford joelanford added this pull request to the merge queue May 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 8, 2024
@perdasilva perdasilva added this pull request to the merge queue May 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 8, 2024
@tmshort
Copy link
Contributor

tmshort commented May 8, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2024
@tmshort tmshort added this pull request to the merge queue May 8, 2024
Merged via the queue into operator-framework:master with commit 232cf32 May 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants