feat(operatorinstaller): add initial deployment strategy #40
Conversation
alm/operatorinstaller.go
Outdated
| import ( | ||
| "encoding/json" | ||
| "fmt" | ||
| "github.com/coreos-inc/operator-client/pkg/client" |
There was a problem hiding this comment.
import (
// std imports
// third party imports
// local imports
)
There was a problem hiding this comment.
Does the go fmt not really fix this?
There was a problem hiding this comment.
goimports does iirc, but i personally don't run it on save because it has corner-cases, specifically the prometheus client lib confuses it a lot
| return nil, err | ||
| } | ||
| crd := &v1beta1extensions.CustomResourceDefinition{} | ||
| _, _, err = scheme.Codecs.UniversalDecoder().Decode(data, nil, crd) |
There was a problem hiding this comment.
these libraries suck
They use io.Writer for encoding, but []byte for decoding instead of io.Reader.
There was a problem hiding this comment.
8fe6dc4 so much in these packages is just so 😞 . Added comment that this is for testing things out, not production use cases.
schema/loader.go
Outdated
| @@ -7,6 +7,8 @@ import ( | |||
| "k8s.io/client-go/kubernetes/scheme" | |||
| ) | |||
|
|
|||
| // LoadCRDFromFile is a utility function for loading the CRD schemas. | |||
| // !!! WARNING !!! Not recommended for production use | |||
There was a problem hiding this comment.
If this is the case, we could put it in a test file
There was a problem hiding this comment.
that's where it was originally but it doesn't really belong in any of the packages being tested, so I put it in it's own thing for now.
|
Looks like there's a vendoring issue with CI |
| } | ||
|
|
||
| func deploymentFromUnstructured(d *unstructured.Unstructured) (*v1beta1.Deployment, error) { | ||
| data, err := json.Marshal(d) |
There was a problem hiding this comment.
Is there a reason we can't cast to a deployment here?
|
|
||
| mockClient := client.NewMockInterface(ctrl) | ||
|
|
||
| mockClient.EXPECT(). |
There was a problem hiding this comment.
Should test the error case too
ecordell
force-pushed
the
ericavonb/ALM-111/alm-code-skeleton-operatorversion
branch
7 times, most recently
from
846357c
to
a7daa52
Compare
ecordell
force-pushed
the
ericavonb/ALM-111/alm-code-skeleton-operatorversion
branch
from
a7daa52
to
16065f9
Compare
charltonaustin
force-pushed
the
ericavonb/ALM-111/alm-code-skeleton-operatorversion
branch
from
16065f9
to
ee6916f
Compare
ecordell
force-pushed
the
ericavonb/ALM-111/alm-code-skeleton-operatorversion
branch
from
ee6916f
to
dabc0e7
Compare
jzelinskie
deleted the
ericavonb/ALM-111/alm-code-skeleton-operatorversion
branch
…M-111/alm-code-skeleton-operatorversion feat(operatorinstaller): add initial deployment strategy
Add beginning of operator install strategy logic by adding the "deployment" strategy.