Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRPC deprecation utests #1163

Closed
4 tasks done
grokspawn opened this issue Nov 9, 2023 · 1 comment · Fixed by #1164
Closed
4 tasks done

GRPC deprecation utests #1163

grokspawn opened this issue Nov 9, 2023 · 1 comment · Fixed by #1164

Comments

@grokspawn
Copy link
Contributor

grokspawn commented Nov 9, 2023 •
edited

In order to make the new deprecation schema available over the GRPC API, we performed testing manually. In order to remain robust we need to include unit tests to exercise

  1. declcfg.ConvertToModel
    • deprecation with no Package string
    • deprecations against bundles/channels/packages not in current DeclarativeConfig
    • more than 1 deprecation against same package
    • PackageScopedReference with unsupported schema/empty
    • duplicate PackageScopedReference (same target)
  2. declcfg.WriteFS with deprecations
  3. model.(*Deprecation)Validate() empty deprecation message
  4. api.GetBundle, api.GetChannel, api.GetPackage with deprecations (FBC w/deps starts GRPC server and we can get these)
This was referenced Nov 9, 2023
Closed
Merged
@grokspawn
Copy link
Contributor Author

Closed wrong issue. Whoops!

@grokspawn grokspawn reopened this Nov 16, 2023
@grokspawn grokspawn mentioned this issue Nov 16, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecation utests grokspawn/operator-registry
1 participant
@grokspawn