Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc changes, model conversion, validation #1161

Conversation

grokspawn
Copy link
Contributor

@grokspawn grokspawn commented Nov 6, 2023

Description of the change:
Contributes to #1154

NB: this is declarativeconfig --> grpc path only, right now. We need future issues for

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2023
@grokspawn grokspawn force-pushed the deprecation_grpc_model branch 2 times, most recently from 17f4672 to 4693570 Compare November 6, 2023 20:19
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 114 lines in your changes are missing coverage. Please review.

Comparison is base (f2285a2) 53.76% compared to head (26a9f82) 53.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1161      +/-   ##
==========================================
- Coverage   53.76%   53.32%   -0.45%     
==========================================
  Files         108      108              
  Lines       10237    10337     +100     
==========================================
+ Hits         5504     5512       +8     
- Misses       3755     3841      +86     
- Partials      978      984       +6     
Files Coverage Δ
alpha/declcfg/declcfg.go 82.60% <ø> (ø)
alpha/declcfg/write.go 67.58% <ø> (+0.79%) ⬆️
pkg/registry/types.go 29.21% <ø> (ø)
pkg/api/model_to_api.go 48.85% <40.00%> (-0.36%) ⬇️
pkg/cache/pkgs.go 72.72% <71.42%> (-1.77%) ⬇️
alpha/model/model.go 88.34% <18.18%> (-5.08%) ⬇️
pkg/registry/conversion.go 35.29% <0.00%> (-8.61%) ⬇️
pkg/api/registry_grpc.pb.go 0.00% <0.00%> (ø)
alpha/declcfg/declcfg_to_model.go 71.72% <15.00%> (-21.92%) ⬇️
pkg/api/registry.pb.go 2.81% <2.63%> (-0.17%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/api/registry.proto Outdated Show resolved Hide resolved
@grokspawn grokspawn mentioned this pull request Nov 8, 2023
3 tasks
@grokspawn grokspawn force-pushed the deprecation_grpc_model branch 2 times, most recently from 0929bc3 to 1c9bbc6 Compare November 8, 2023 22:52
pkg/api/registry.proto Outdated Show resolved Hide resolved
@grokspawn grokspawn force-pushed the deprecation_grpc_model branch 5 times, most recently from c0757aa to 9673f6c Compare November 9, 2023 20:01
@grokspawn grokspawn changed the title WIP: grpc changes, model conversion, validation grpc changes, model conversion, validation Nov 9, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 9, 2023
alpha/declcfg/write.go Outdated Show resolved Hide resolved
@joelanford
Copy link
Member

I think this looks good to me implementation-wise. What are you thinking re: tests?

@grokspawn
Copy link
Contributor Author

I think this looks good to me implementation-wise. What are you thinking re: tests?

Tracked in #1163

Copy link
Contributor

openshift-ci bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grokspawn grokspawn mentioned this pull request Nov 13, 2023
5 tasks
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@joelanford
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit f7c6429 into operator-framework:master Nov 13, 2023
10 of 13 checks passed
@grokspawn grokspawn deleted the deprecation_grpc_model branch November 14, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants