Deprecation utests #1164
Deprecation utests #1164
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
grokspawn
force-pushed
the
deprecation_utest
branch
from
a8eb1b4
to
8438da4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1164 +/- ##
==========================================
+ Coverage 53.32% 53.67% +0.35%
==========================================
Files 108 108
Lines 10337 10340 +3
==========================================
+ Hits 5512 5550 +38
+ Misses 3841 3808 -33
+ Partials 984 982 -2 ☔ View full report in Codecov by Sentry. |
grokspawn
force-pushed
the
deprecation_utest
branch
3 times, most recently
from
8960594
to
ccc7bac
Compare
| @@ -291,7 +440,7 @@ func TestConvertToModel(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestConvertToModelRoundtrip(t *testing.T) { | |||
| expected := buildValidDeclarativeConfig(true) | |||
| expected := buildValidDeclarativeConfig(validDeclarativeConfigSpec{IncludeUnrecognized: true, IncludeDeprecations: false}) // TODO: turn on deprecation when we have model-->declcfg conversion | |||
There was a problem hiding this comment.
This function goes declcfg --> model --> declcfg and compares the start and finish products. We don't yet have backwards conversion, so this can't be enabled until #1162 lands.
| @@ -19,7 +19,7 @@ func TestConvertFromModel(t *testing.T) { | |||
| { | |||
| name: "Success", | |||
| m: buildTestModel(), | |||
| expectCfg: buildValidDeclarativeConfig(false), | |||
| expectCfg: buildValidDeclarativeConfig(validDeclarativeConfigSpec{IncludeUnrecognized: false, IncludeDeprecations: false}), | |||
There was a problem hiding this comment.
#1162 will make this false, true
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
grokspawn
force-pushed
the
deprecation_utest
branch
from
ccc7bac
to
aabac5e
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
I'll happily give this an |
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
|
/lgtm |
openshift-merge-bot
bot
merged commit 39df3b7
into
operator-framework:master
Follows #1161. Contributes to #1154. Closes #1163
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs