Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s dependencies to v0.28.5 #1176

Conversation

Neo2308
Copy link
Contributor

@Neo2308 Neo2308 commented Jan 9, 2024

Update k8s dependencies to v0.28.5
Update operator-framework/api dependency which has k8s 1.28 changes

Relates to: operator-framework/operator-sdk#6554

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 9, 2024
Copy link
Contributor

openshift-ci bot commented Jan 9, 2024

Hi @Neo2308. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Neo2308 Neo2308 force-pushed the feature/master/bump-k8s-0.28.4 branch from 25188e3 to 6d5e4ab Compare January 9, 2024 18:44
@grokspawn
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9446132) 53.79% compared to head (60b4b93) 53.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1176      +/-   ##
==========================================
- Coverage   53.79%   53.77%   -0.02%     
==========================================
  Files         108      108              
  Lines       10367    10367              
==========================================
- Hits         5577     5575       -2     
- Misses       3808     3810       +2     
  Partials      982      982              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Neo2308 Neo2308 changed the title Update k8s dependencies to v0.28.4 Update k8s dependencies to v0.28.5 Jan 9, 2024
@joelanford
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2024
Copy link
Contributor

openshift-ci bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford, Neo2308

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2024
@grokspawn
Copy link
Contributor

Needs merge conflicts resolved.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2024
Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>
Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>
@joelanford joelanford force-pushed the feature/master/bump-k8s-0.28.4 branch from 7f6f2b8 to 60b4b93 Compare January 10, 2024 13:17
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2024
@joelanford
Copy link
Member

I rebased and removed the operator-framework/api dependency change. Let's do that one separately.

@joelanford
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 588aab9 into operator-framework:master Jan 10, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants