Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update operator-bundle to clarify the bundle format directories #172

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Update operator-bundle to clarify the bundle format directories #172

merged 1 commit into from
Feb 19, 2020

Conversation

dinhxuanvu
Copy link
Member

  1. Remove the bundle manifest format reference to README to avoid
    duplicate information.
  2. Add a new section for Bundle Manifest Format to include format
    information
  3. Add notes regarding the manifests and metadata constants
  4. Clean up the bundle generate section to make directory info
    clearer and more intuitive.

Signed-off-by: Vu Dinh vdinh@redhat.com

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 4, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2020
@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Update operator-bundle to clarify the bundle format directories
b20cc7d 
1. Remove the bundle manifest format reference to README to avoid
duplicate information.
2. Add a new section for Bundle Manifest Format to include format
information
3. Add notes regarding the manifests and metadata constants
4. Clean up the bundle generate section to make directory info
clearer and more intuitive.

Signed-off-by: Vu Dinh <vdinh@redhat.com>
@benluddy
Copy link
Contributor

benluddy commented Feb 5, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dinhxuanvu
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit efd7a82 into operator-framework:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benluddy benluddy benluddy left review comments

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

@njhale njhale Awaiting requested review from njhale

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

@ecordell ecordell Awaiting requested review from ecordell

Assignees

@benluddy benluddy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dinhxuanvu @benluddy @openshift-ci-robot @openshift-bot @openshift-merge-robot