(feat): Bundle commutativity #285
Conversation
`opm registry add` and `opm index add`, when presented with multiple bundles, required that those bundles be in version order when inserting in replaces mode. This requirement existed because bundles are inserted into the database in order, and if one of these bundles replaces another the db schema would reject the insert. This commit updates the replaces mode insert logic to check the existing package graph and attempt to insert bundles in order. As a followup to this commit, once we define a method of inserting in replaces mode based on a graph input, we should be able to reduce this to a single db transaction by defining the graph as a set of the existing db + new input bundles. This would also simplify error handling, which would no longer need any database transactions.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
| err = i.loadManifestsReplaces(bundle, annotationsFile) | ||
| if err != nil { | ||
| return err | ||
| // TODO: This is relatively inefficient. Ideally, we should be able to use a replaces |
There was a problem hiding this comment.
This comment is also my main comment - we have a lot of the lower level stuff in place to do this really efficiently now.
But I don't think that needs to block
There was a problem hiding this comment.
yeah, looking at it it was just going to take a lot more time and effort to reimplement some of the sql layer to do that, so I opted for this initial implementation to get it out there and kicked the can down the road somewhat.
as for a test, not explicitly called out, but the root db populate now generates the database with out of order input: https://github.com/operator-framework/operator-registry/pull/285/files#diff-bac4eb64785fb97243acdc492eedd162R70
|
/lgtm |
opm registry addandopm index add, when presented with multiplebundles, required that those bundles be in version order when inserting
in replaces mode. This requirement existed because bundles are inserted
into the database in order, and if one of these bundles replaces another
the db schema would reject the insert.
This commit updates the replaces mode insert logic to check the existing
package graph and attempt to insert bundles in order.
As a followup to this commit, once we define a method of inserting in
replaces mode based on a graph input, we should be able to reduce this
to a single db transaction by defining the graph as a set of the
existing db + new input bundles. This would also simplify error handling,
which would no longer need any database transactions.
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs