Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): Bundle commutativity #285

Commits on Apr 17, 2020

  1. (feat): Bundle commutativity

    `opm registry add` and `opm index add`, when presented with multiple
    bundles, required that those bundles be in version order when inserting
    in replaces mode. This requirement existed because bundles are inserted
    into the database in order, and if one of these bundles replaces another
    the db schema would reject the insert.
    
    This commit updates the replaces mode insert logic to check the existing
    package graph and attempt to insert bundles in order.
    
    As a followup to this commit, once we define a method of inserting in
    replaces mode based on a graph input, we should be able to reduce this
    to a single db transaction by defining the graph as a set of the
    existing db + new input bundles. This would also simplify error handling,
    which would no longer need any database transactions.
    kevinrizza committed Apr 17, 2020
    Copy the full SHA
    dced648 View commit details
    Browse the repository at this point in the history