Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1846100: fix(server): make a copy of the db before migrating it #356

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Bug 1846100: fix(server): make a copy of the db before migrating it #356

merged 1 commit into from
Jun 19, 2020

Conversation

ecordell
Copy link
Member

Manual cherry-pick of #332

@ecordell
fix(server): make a copy of the db before migrating it
5f77bde 
if the server is run when it has read-only access to a database, it will
fail to migrate. this commit will cause the server to always copy the
database on start, so that it is always rw and can be migrated.
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 10, 2020
@openshift-ci-robot
Copy link

@ecordell: This pull request references Bugzilla bug 1846100, which is invalid:

  • expected the bug to target the "4.4.z" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1846100: fix(server): make a copy of the db before migrating it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2020
@ecordell
Copy link
Member Author

/bugzilla refresh

@ecordell
Copy link
Member Author

/cherry-pick release-4.3

@ecordell ecordell mentioned this pull request Jun 10, 2020
Closed
@ecordell
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 10, 2020
@openshift-ci-robot
Copy link

@ecordell: This pull request references Bugzilla bug 1846100, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.z) matches configured target release for branch (4.4.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1827612 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1827612 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Bowenislandsong
Copy link
Member

/lgtm

@sferich888
Copy link

@ecordell are we planning on also manually creating a backport for 4.3? or will we try and cherry pick this back to 4.3?

@Bowenislandsong
Copy link
Member

/retest

@Bowenislandsong Bowenislandsong added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@kevinrizza
Copy link
Member

/test e2e-aws

@ecordell
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 19, 2020
@openshift-merge-robot openshift-merge-robot merged commit 3069d8c into operator-framework:release-4.4 Jun 19, 2020
@openshift-ci-robot
Copy link

@ecordell: All pull requests linked via external trackers have merged: operator-framework/operator-registry#356. Bugzilla bug 1846100 has been moved to the MODIFIED state.

In response to this:

Bug 1846100: fix(server): make a copy of the db before migrating it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@ecordell: new pull request created: #364

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

@njhale njhale Awaiting requested review from njhale

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ecordell @openshift-ci-robot @Bowenislandsong @sferich888 @openshift-bot @kevinrizza @openshift-cherrypick-robot @bparees @openshift-merge-robot