Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1866861: 4.5 index images should work with 4.6 catalog operator. #434

Merged
merged 3 commits into from Sep 4, 2020
Merged

Bug 1866861: 4.5 index images should work with 4.6 catalog operator. #434

merged 3 commits into from Sep 4, 2020

Conversation

benluddy
Copy link
Contributor

@benluddy benluddy commented Sep 4, 2020

The ListBundles endpoint was introduced to the registry API in 4.5, but was not consumed by any clients. Several necessary changes to ListBundles were identified as part of changes to dependency resolution in 4.6. Since 4.5.z indexes must work on 4.6 clusters, ListBundles must be minimally functional in 4.5.

@benluddy
Backport exposure of skips and replaces to ListBundles responses (ope…
9aedff0 
…rator-framework#381).
@benluddy
Return empty dependencies in ListBundles responses.
3c92cd5 
Bundles that don't have any dependencies should return nil or [] for
those fields, but due to an error in handling NULL column values, a
single zero-valued entry was being returned.
@benluddy
Backport returning bundles in all channels from ListBundles (operator…
ae2413c 
…-framework#410).
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Sep 4, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 4, 2020
@openshift-ci-robot
Copy link

@benluddy: This pull request references Bugzilla bug 1866861, which is invalid:

  • expected dependent Bugzilla bug 1866860 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is CLOSED (NOTABUG) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1866861: 4.5 index images should work with 4.6 catalog operator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ecordell
ecordell approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold
for second lgtm

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2020
@kevinrizza
Copy link
Member

/lgtm
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2020
@ecordell ecordell added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 4, 2020
@derekwaynecarr derekwaynecarr added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 4, 2020
@openshift-merge-robot openshift-merge-robot merged commit ff05bb7 into operator-framework:release-4.5 Sep 4, 2020
@openshift-ci-robot
Copy link

@benluddy: All pull requests linked via external trackers have merged:

Bugzilla bug 1866861 has been moved to the MODIFIED state.

In response to this:

Bug 1866861: 4.5 index images should work with 4.6 catalog operator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecordell ecordell ecordell approved these changes

@awgreene awgreene Awaiting requested review from awgreene

@njhale njhale Awaiting requested review from njhale

Assignees

@ecordell ecordell

@kevinrizza kevinrizza

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@benluddy @openshift-ci-robot @kevinrizza @ecordell @derekwaynecarr @openshift-merge-robot