Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(loader): don't require file suffixes #45

Merged
merged 1 commit into from
Apr 25, 2019
Merged

feat(loader): don't require file suffixes #45

merged 1 commit into from
Apr 25, 2019

Conversation

ecordell
Copy link
Member

@ecordell ecordell commented Apr 16, 2019 •
edited
Loading

Changes the loader to identify csvs and packages based on contents, not on file names.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 16, 2019
tkashem
tkashem approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@tkashem tkashem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's robust that we don't require file suffixes to follow any pattern as far as operator registry is concerned. In addition, I believe the tools/pipeline can follow a naming convention so that all operator manifests have a consistent layout.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ecordell
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit ea142d6 into operator-framework:master Apr 25, 2019
@ecordell ecordell deleted the permissive-files branch May 21, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkashem tkashem tkashem approved these changes

@jpeeler jpeeler Awaiting requested review from jpeeler

@njhale njhale Awaiting requested review from njhale

Assignees

@tkashem tkashem

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ecordell @openshift-ci-robot @tkashem @openshift-merge-robot