Bug 1889721: Check prerelease version for semver-skippatch mode #486
Conversation
openshift-ci-robot
added
the
bugzilla/severity-high
|
@ankitathomas: This pull request references Bugzilla bug 1889721, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@ankitathomas: This pull request references Bugzilla bug 1889721, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -154,5 +154,5 @@ func (g *BundleGraphLoader) AddBundleToGraph(bundle *Bundle, graph *Package, ann | |||
| } | |||
|
|
|||
| func isSkipPatchCandidate(version, toCompare semver.Version) bool { | |||
There was a problem hiding this comment.
| func isSkipPatchCandidate(version, toCompare semver.Version) bool { | |
| // isSkipPatchCandidate returns true if version is equal to toCompare | |
| // in major and minor positions and strictly greater in all others, | |
| // indicating that toCompare can be skipped over to version. | |
| func isSkipPatchCandidate(version, toCompare semver.Version) bool { |
ankitathomas
force-pushed
the
skippatch-fix
branch
from
2056e71
to
d8243c5
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitathomas, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
/cherry-pick release-4.6 |
|
@njhale: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ankitathomas: All pull requests linked via external trackers have merged: Bugzilla bug 1889721 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@njhale: new pull request created: #488 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Switch to using semver's compare to decide semver-skippatch candidates