[release-4.6] Bug 1891064: Check prerelease version for semver-skippatch mode

[openshift-cherrypick-robot]

This is an automated cherry-pick of #486

/assign njhale

[openshift-ci-robot]

@openshift-cherrypick-robot: Bugzilla bug 1889721 has been cloned as Bugzilla bug 1891064. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1891064: Check prerelease version for semver-skippatch mode

In response to this:

[release-4.6] Bug 1889721: Check prerelease version for semver-skippatch mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1891064, which is invalid:

• expected dependent Bugzilla bug 1889721 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 1891064: Check prerelease version for semver-skippatch mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[njhale]

@ankitathomas We probably want to add tests for this in master, merge it, then add the test commit back to this PR.

Holding until tests are added.

/hold

[njhale]

Thanks for adding the tests! Don't mind the nit, I only pointed it out for next time.

/hold cancel
/approve

[njhale]

nit: import order

remember, even with goimports, we still need to organize the imports into the correct groups; e.g.

import (
    <standard>
    
    <external orgs>

    <same org>
)

[ankitathomas]

It'd be nice if go fmt did this for free

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [njhale]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kevinrizza]

/lgtm

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[ecordell]

/bugzilla refresh

[openshift-ci-robot]

@ecordell: This pull request references Bugzilla bug 1891064, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.z) matches configured target release for branch (4.6.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1889721 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1889721 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
• bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

• operator-framework/operator-registry#488

Bugzilla bug 1891064 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1891064: Check prerelease version for semver-skippatch mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.