[release-4.6] Bug 1898746: fix(indexing): order bulk add by version field #521
Conversation
openshift-ci-robot
added
bugzilla/severity-high
|
@njhale: This pull request references Bugzilla bug 1898746, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
njhale
force-pushed
the
4.6-fix-bulk-add
branch
from
093fce0
to
691ea5f
Compare
|
/retest |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold some weirdness going on here |
openshift-ci-robot
added
the
do-not-merge/hold
|
/test images |
|
@njhale: This pull request references Bugzilla bug 1898746, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
njhale
force-pushed
the
4.6-fix-bulk-add
branch
2 times, most recently
from
18f7726
to
416b8f4
Compare
|
/hold cancel Was unintentionally bumping k8s deps to 1.19, which pulled in a transitive dep that underwent a file name case-change, which confused my case-insensitive -- but case-preservative -- macos filesystem; Git did not pick up the changes to the file name in the vendor directory, and CI -- both travis and openshift -- determined there was a missing dependency. I removed the 1.19 bump and it looks like the builds are working now. Thanks @benluddy for your help! |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@openshift-bot: This pull request references Bugzilla bug 1898746, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1898746, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1898746, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1898746, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1898746, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold There are some questions about whether this is causing a regression in master. More details to follow. |
openshift-ci-robot
added
the
do-not-merge/hold
Ensure the default channel referenced by a bundle exists, either by that bundle or in the package, before returning it as the next element of an input stream. Adding this check prevents smaller versions from breaking index add when the `--overwrite-latest` flag is set; e.g. if a z-stream bundle was originally added _after_ a larger y-stream and references a default channel only defined in that y-stream.
|
@njhale: This pull request references Bugzilla bug 1898746, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2 similar comments
|
@njhale: This pull request references Bugzilla bug 1898746, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@njhale: This pull request references Bugzilla bug 1898746, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold cancel Regressions fixed and included in this patch. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@njhale: This pull request references Bugzilla bug 1898746, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, hasbro17, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/bugzilla refresh |
|
@eparis: This pull request references Bugzilla bug 1898746, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
eparis
added
the
cherry-pick-approved
|
@njhale: All pull requests linked via external trackers have merged: Bugzilla bug 1898746 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manual cherry-pick of #503 and two updates to fix its defects:
When adding more than one bundle to an index in replaces mode, sort the input by order of ascending version field (semver). This ensures a deterministic update graph in the absence of a replaces field.
The replaces field takes priority.