Bug 1902824: fix(index): account for default channel in index add order #528
Conversation
Ensure the default channel referenced by a bundle exists, either by that bundle or in the package, before returning it as the next element of an input stream. Adding this check prevents smaller versions from breaking index add when the `--overwrite-latest` flag is set; e.g. if a z-stream bundle was originally added _after_ a larger y-stream and references a default channel only defined in that y-stream.
openshift-ci-robot
added
the
bugzilla/severity-high
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@njhale: This pull request references Bugzilla bug 1902824, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gallettilance, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
==========================================
+ Coverage 49.31% 49.38% +0.07%
==========================================
Files 90 90
Lines 6302 6311 +9
==========================================
+ Hits 3108 3117 +9
Misses 2498 2498
Partials 696 696
Continue to review full report at Codecov.
|
|
@njhale: All pull requests linked via external trackers have merged: Bugzilla bug 1902824 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ensure the default channel referenced by a bundle exists, either by that
bundle or in the package, before returning it as the next element of an
input stream. Adding this check prevents smaller versions from breaking
index add when the
--overwrite-latestflag is set; e.g. if a z-streambundle was originally added after a larger y-stream and references a
default channel only defined in that y-stream.