pkg/scaffold: update to controller-runtime v0.1.10 and k8s 1.13.1 #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
hasbro17
force-pushed
the
update-controller-runtime-0.1.10
branch
from
188815d
to
83615f2
Compare
hasbro17
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
hasbro17
force-pushed
the
update-controller-runtime-0.1.10
branch
from
83615f2
to
cc1cf8e
Compare
openshift-ci-robot
added
the
needs-rebase
hasbro17
force-pushed
the
update-controller-runtime-0.1.10
branch
from
cc1cf8e
to
292770e
Compare
openshift-ci-robot
removed
the
needs-rebase
hasbro17
changed the title
|
The CI is finally passing. https://github.com/operator-framework/operator-sdk/blob/master/pkg/scaffold/cmd.go#L47-L48 https://github.com/operator-framework/operator-sdk/blob/master/pkg/scaffold/controller_kind.go#L47-L49 |
estroz
approved these changes
Jan 31, 2019
|
Forgot to update the CHANGELOG. I'll do a follow up for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Update the dep constraints for the controller-runtime version to
v0.1.10and the k8s.io deps tokubernetes-1.13.1.Also removed the requirement for the
k8s.io/code-generator/cmd/openapi-genpkg since that has been moved to the repok8s.io/kube-openapi.Motivation for the change:
Lagging behind the latest controller-runtime updates.