ansible/controller,helm/controller: reconcile controller to use cache #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
added
kind/bug
openshift-ci-robot
added
the
size/S
joelanford
approved these changes
Jan 31, 2019
|
let's keep it in mind but @hasbro17 is close with the bump and the other way is easy to implement IMO so I would wait. Both changes are small though so not a big deal either way if you feel strongly I can cherry-pick. |
|
Yeah I just approved #1020, so I'm good with waiting. If we get to the point of making a release, we can always cherry pick this if necessary. |
shawn-hurley
force-pushed
the
bugfix/use-cache-for-unstructured
branch
from
83c76d8
to
b64ce51
Compare
shawn-hurley
force-pushed
the
bugfix/use-cache-for-unstructured
branch
from
b64ce51
to
8c010d4
Compare
shawn-hurley
pushed a commit
to shawn-hurley/operator-sdk
that referenced
this pull request
Apr 23, 2019
…operator-framework#1022) <!-- Before making a PR, please read our contributing guidelines https://github.com/operator-framework/operator-sdk/blob/master/CONTRIBUTING.MD Note: Make sure your branch is rebased to the latest upstream master. --> **Description of the change:** Set the reconciler to use the cache for a Reader. **Motivation for the change:** The delegating reader will proxy unstructured calls to the API and not use the cache. This is specifically for 0.4.0, there is a better mechanism when using controller-runtime v0.1.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Set the reconciler to use the cache for a Reader.
Motivation for the change:
The delegating reader will proxy unstructured calls to the API and not use the cache.
This is specifically for 0.4.0, there is a better mechanism when using controller-runtime v0.1.10