Add global --verbose flag to operator-sdk command

[briantopping]

Description of the change:
Add global --verbose flag to operator-sdk command. The scorecard command has a verbose option, but this is better defined as a single global flag. The initial use of the flag is to add a log.Debugf call to see the exec calls that are being made.

Motivation for the change:
Experimenting with creating a Bazel build around the generated project from operator-sdk. It was not clear what was actually happening at the runtime exec calls.

[openshift-ci-robot]

Hi @briantopping. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[estroz]

/cc @hasbro17 @joelanford @AlexNPavel @lilic

[estroz]

/ok-to-test

[joelanford]

We're able to remove other uses of VerboseOpt in the scorecard code with this change as well, correct?

operator-sdk/internal/pkg/scorecard/scorecard.go

Line 64 in 1d10eb7

VerboseOpt = "verbose"

operator-sdk/cmd/operator-sdk/scorecard/cmd.go

Line 54 in 1d10eb7

scorecardCmd.Flags().Bool(scorecard.VerboseOpt, false, "Enable verbose logging")

[briantopping]

@joelanford Good eye, I should have done a global search.

Now I'm interested in whether we ought to interact with --v=, which has different dimensionality:

operator-sdk/internal/util/projutil/project_util.go

Lines 191 to 196 in fc22a33

	// IsGoVerbose returns true if GOFLAGS contains "-v". This function is useful
	// when deciding whether to make "go" command output verbose.
	func IsGoVerbose() bool {
	gf, ok := os.LookupEnv(GoFlagsEnv)
	return ok && len(gf) != 0 && flagRe.MatchString(gf)
	}

[estroz]

@briantopping it would be nice to rely on --verbose instead of GOFLAGS globally. We could set GOFLAGS="-v" if --verbose is set instead of checking manually.

[briantopping]

/retest

[briantopping]

/shrug

[shawn-hurley]

I think a leftover debug statement but LGTM

[estroz]

/lgtm

[lilic]

One nit otherwise lgtm, thanks for your contribution! 👍

[lilic]

/lgtm

[openshift-ci-robot]

New changes are detected. LGTM label has been removed.

[briantopping]

@lilic No idea why

operator-sdk/hack/check_error_log_msg_format.sh

Line 10 in 3c2fee5

log_case_output=$(grep -PRn '(Error\((.*[Ee]rr|nil), |^(?!.*fmt).+\.Error(f)?\(|Fatal(f)?\(|Info(f)?\(|Warn(f)?\()"[[:lower:]]' $allfiles | sort -u)

is failing now. These uppercase strings were there since the start of my PR, now they suddenly emerge after your review!

[AlexNPavel]

@briantopping Travis tests aren't managed by API CI so sadly we can't trigger retests with comments. If you hit details, there should be a restart test button on the web page. I'll restart the failed test for you now

[hasbro17]

@briantopping Looks good overall.
One last thing: Can you please document the behavior of the global --verbose flag in the sdk-cli-reference.md doc.
You can add a line right at the top before the first section for the build command.

Additionally we want to point out this change in the Added section of the CHANGELOG.

[briantopping]

@hasbro17 all set!

[joelanford]

LGTM

[briantopping]

Thanks all! Grateful for your patience while I came up-to-speed with contributing to this project! 😄