Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global --verbose flag to operator-sdk command #1361

Merged
merged 13 commits into from
May 2, 2019
Merged

Add global --verbose flag to operator-sdk command #1361

merged 13 commits into from
May 2, 2019

Commits on Apr 30, 2019

  1. Add global --verbose flag to operator-sdk command 

    Description of the change: The `scorecard` command has a verbose option, but this is better defined as a single global flag. The initial use of the flag is to add a `log.Debugf` call to see the `exec` calls that are being made.

Signed-off-by: Brian Topping <brian@coglative.com>
    @briantopping
    briantopping committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    1d10eb7 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2019

  1. Updates from comments 

    Signed-off-by: Brian Topping <brian@coglative.com>
    @briantopping
    briantopping committed May 1, 2019
    Configuration menu
    Copy the full SHA
    28bad08 View commit details
    Browse the repository at this point in the history

  2. Fix missing header, redundant call. 

    Signed-off-by: Brian Topping <brian@coglative.com>
    @briantopping
    briantopping committed May 1, 2019
    Configuration menu
    Copy the full SHA
    b97ca71 View commit details
    Browse the repository at this point in the history

  3. Update cmd/operator-sdk/main.go 

    Thanks. I had considered the two options, the error situations seemed rare and the worst that would happen is execution continued with debug turned off (instead of not running at all. I'm still learning stylisms so noted... :)

Co-Authored-By: briantopping <brian.topping@gmail.com>
    @briantopping
    Eric Stroczynski and briantopping committed May 1, 2019
    Configuration menu
    Copy the full SHA
    fa1756c View commit details
    Browse the repository at this point in the history

  4. Additional updates from comments, thanks guys! 

    Signed-off-by: Brian Topping <brian@coglative.com>
    @briantopping
    briantopping committed May 1, 2019
    Configuration menu
    Copy the full SHA
    cb4d58a View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/verbose-flag' into verbose-flag

    @briantopping
    briantopping committed May 1, 2019
    Configuration menu
    Copy the full SHA
    96de13d View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/master' into verbose-flag 

    # Conflicts:
#	cmd/operator-sdk/scorecard/cmd.go
#	internal/pkg/scorecard/scorecard.go
    @briantopping
    briantopping committed May 1, 2019
    Configuration menu
    Copy the full SHA
    779af85 View commit details
    Browse the repository at this point in the history

  7. Merge latest master, additional cleanups from @estroz. 

    Signed-off-by: Brian Topping <brian@coglative.com>
    @briantopping
    briantopping committed May 1, 2019
    Configuration menu
    Copy the full SHA
    2504e2f View commit details
    Browse the repository at this point in the history

Commits on May 2, 2019

  1. Update cmd/operator-sdk/main.go 

    Great eye! Thanks @lilic, noted for future use! :)

Co-Authored-By: briantopping <brian.topping@gmail.com>
    @lilic @briantopping
    lilic and briantopping committed May 2, 2019
    Configuration menu
    Copy the full SHA
    7bc74dc View commit details
    Browse the repository at this point in the history

  2. Not sure what's going on with sanity check. 

    Signed-off-by: Brian Topping <brian@coglative.com>
    @briantopping
    briantopping committed May 2, 2019
    Configuration menu
    Copy the full SHA
    1709481 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/verbose-flag' into verbose-flag

    @briantopping
    briantopping committed May 2, 2019
    Configuration menu
    Copy the full SHA
    fc9df3a View commit details
    Browse the repository at this point in the history

  4. Reverting case sensitivity on strings re: @estroz comment. 

    Signed-off-by: Brian Topping <brian@coglative.com>
    @briantopping
    briantopping committed May 2, 2019
    Configuration menu
    Copy the full SHA
    fc48b3a View commit details
    Browse the repository at this point in the history

  5. Documentation and changelog 

    Signed-off-by: Brian Topping <brian@coglative.com>
    @briantopping
    briantopping committed May 2, 2019
    Configuration menu
    Copy the full SHA
    f2b551c View commit details
    Browse the repository at this point in the history