Add --operator-name flag to olm-catalog gen-csv

[nikhil-thomas]

Description of the change:
This patch adds a flag --operator-name to specify the operator name
while generating CSV using operator-sdk gen-csv command

The default value (when flag is absent) is base directory name as before

Motivation for the change:
At present operator-sdk assumes project-directory-name (ProjectName) is the operator name.
The operator-name and the project-directory-name can be different.
(because of change in source control, project home, organizational policies etc)

Without an --operator-name flag we will have to rename, copy-paste generated CSVs

Signed-off-by: Nikhil Thomas nikthoma@redhat.com

[estroz]

There are a few other changes required to use a different CSV name and path simultaneously in a reliable manner.

An OperatorName field should be added to scaffold.CSV so input.ProjectName can be used elsewhere as expected. OperatorName should be populated as ProjectName is currently, and used instead of ProjectName in internal/pkg/scaffold/olm-catalog/csv.go where relevant. The --project-name flag should be renamed to --operator-name.

[joelanford]

Are there currently (or do we envision in the future) any other subcommands that would need a similar flag? I wonder if we should add this flag to the operator-sdk new command instead, and populate a config file in the project root that contains the value, then any other commands that need it could just pull it from there?

[estroz]

@joelanford yes especially with OLM additions coming. There are quite a few changes to be made before we have a global config, but we can add it to the CSV config for now as operator-name. Other commands can access it that way.

[nikhil-thomas]

@estroz Thank you for the feedback 👍

I have updated my patch based on your review. Could take a look.

[estroz]

Needs changes.

[nikhil-thomas]

@estroz Thank you for the detailed review. I have made the changes.
Could you take a look.

[lilic]

cc @estroz think this is ready for another look.

[estroz]

/lgtm

[estroz]

/cc @joelanford

I'll make a follow-up PR for a operator-name config field.

[joelanford]

/approve