Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/pkg/scaffold/olm-catalog: allow multiple RBAC files in CSV config, add operator-name field #1704

Merged
merged 3 commits into from
Jul 22, 2019
Merged

internal/pkg/scaffold/olm-catalog: allow multiple RBAC files in CSV config, add operator-name field #1704

merged 3 commits into from
Jul 22, 2019

Conversation

estroz
Copy link
Member

@estroz estroz commented Jul 18, 2019 •
edited

Description of the change:

Motivation for the change: users can currently add both Roles and ClusterRoles to their CSV, but they must be in the same file. role-paths allows, for example, a deploy/role.yaml and deploy/cluster_role.yaml to be read and added to a CSV.

See #1571 for operator-name details.

@estroz estroz added the olm-integration Issue relates to the OLM integration label Jul 18, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 18, 2019
@estroz
Copy link
Member Author

estroz commented Jul 19, 2019

/test e2e-aws-helm
/test e2e-aws-ansible
/test images

dmesser
dmesser approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@dmesser dmesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2019
hasbro17
hasbro17 reviewed Jul 19, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2019
@estroz estroz requested a review from hasbro17 July 19, 2019 19:11
@estroz estroz changed the title internal/pkg/scaffold/olm-catalog: allow multiple RBAC files in CSV config internal/pkg/scaffold/olm-catalog: allow multiple RBAC files in CSV config, add operator-name field Jul 19, 2019
hasbro17
hasbro17 approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estroz
Copy link
Member Author

estroz commented Jul 19, 2019

/test e2e-aws-go

@estroz estroz requested a review from joelanford July 22, 2019 17:13
@estroz estroz merged commit ce367cb into operator-framework:master Jul 22, 2019
@estroz estroz deleted the csv-clusterroles branch July 22, 2019 20:53
@camilamacedo86 camilamacedo86 mentioned this pull request Jul 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasbro17 hasbro17 hasbro17 approved these changes

@dmesser dmesser dmesser approved these changes

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

@lilic lilic Awaiting requested review from lilic

@theishshah theishshah Awaiting requested review from theishshah

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@dmesser dmesser

Labels
olm-integration Issue relates to the OLM integration size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@estroz @openshift-ci-robot @hasbro17 @dmesser