Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ansible minimal version in the roles #2107

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Oct 24, 2019

Description of the change:

Use min_ansible_version: 2.6 instead of 2.4

Motivation for the change:

When we upgrade the Ansible Memcached sample from and old version to use 0.10 @fabianvf makes the following comment:

Screenshot 2019-10-24 at 19 11 09

Now, when we were updating it from 0.10 to 0.11 we could check that it has been creating the scaffold project with 2.4 and not 2.6. So, the goal of this PR is solved this.

@camilamacedo86 camilamacedo86 added kind/bug Categorizes issue or PR as related to a bug. language/ansible Issue is related to an Ansible operator project labels Oct 24, 2019
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2019
@camilamacedo86
Copy link
Contributor Author

/test e2e-aws-go
/test e2e-aws-subcommand

@camilamacedo86
Copy link
Contributor Author

HI @fabianvf,

It is a very small change based on your comment. Have you any objection to moving forward with?

Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@camilamacedo86 camilamacedo86 merged commit 082e046 into operator-framework:master Oct 31, 2019
@camilamacedo86 camilamacedo86 deleted the ansible-minimal-version branch October 31, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. language/ansible Issue is related to an Ansible operator project lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants