fix: (ansible) - Errors in the event have not been re-trigging the reconcile. #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/XS
openshift-ci-robot
removed
the
needs-rebase
camilamacedo86
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
issue-2372
branch
from
376395f
to
90bfa4e
Compare
openshift-ci-robot
added
size/M
camilamacedo86
force-pushed
the
issue-2372
branch
from
90bfa4e
to
c2ab559
Compare
camilamacedo86
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
issue-2372
branch
from
c2ab559
to
e60ced6
Compare
camilamacedo86
added
language/ansible
camilamacedo86
force-pushed
the
issue-2372
branch
2 times, most recently
from
5142e28
to
465e68c
Compare
fabianvf
reviewed
Jan 9, 2020
fabianvf
approved these changes
Jan 13, 2020
There was a problem hiding this comment.
/lgtm, @shawn-hurley maybe you want to have a quick look if you have a sec
camilamacedo86
added
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
openshift-ci-robot
added
size/M
camilamacedo86
force-pushed
the
issue-2372
branch
from
d5a45b8
to
1ff21bf
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
Hi @shawn-hurley it was changed could you please give a look and see if it is ok for you now? |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
camilamacedo86
force-pushed
the
issue-2372
branch
from
1ff21bf
to
53fc9fe
Compare
fabianvf
suggested changes
Jan 14, 2020
camilamacedo86
force-pushed
the
issue-2372
branch
from
53fc9fe
to
7cdd8dd
Compare
camilamacedo86
force-pushed
the
issue-2372
branch
from
c69b580
to
2a5b427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Fix issue: #2372
Errors in the event have not been re-trigging the reconcile.
Motivation for the change:
Closes #2372
Notes
Local tests to verify it can be done with the image:
quay.io/camilamacedo86/ansible-operator:devThe user POC in the #2372 was used to check.