deps: bump operator-registry version #3221
Conversation
openshift-ci-robot
requested review from
camilamacedo86,
hasbro17,
jmrodri and
varshaprasad96
openshift-ci-robot
added
the
kind/bug
estroz
force-pushed
the
chore/bump-operator-registry
branch
2 times, most recently
from
329ed3a
to
083eb3f
Compare
estroz
force-pushed
the
chore/bump-operator-registry
branch
from
f462b9c
to
b34e85a
Compare
that causes validation errors when an existing `annotations.yaml` does not exactly match the default annotations generated by `operator-sdk bundle create`. deps: bump operator-registry cmd/operator-sdk/bundle,internal/scorecard/alpha/tests: the `NewImageValidator` API changed such that the command must create an image registry first before creating a validator.
estroz
force-pushed
the
chore/bump-operator-registry
branch
from
b34e85a
to
24a4a96
Compare
There was a problem hiding this comment.
Just a few nits, see the comments over fix import order and suggestion for a description more user-friendly. And then, we can address the additionals concerns in #3222,
Otherwise,
/lgtm
/approve
estroz
force-pushed
the
chore/bump-operator-registry
branch
from
24a4a96
to
dd3232a
Compare
| - description: > | ||
| Fix bug in `operator-sdk bundle validation` that causes erroneous validation errors when the number of | ||
| annotations in an existing `annotations.yaml` does not equal the number of default bundle annotations | ||
| by upgrading the `operator-registry` dependency. |
There was a problem hiding this comment.
Nit. The command should be operator-sdk bundle validate.
|
/cherry-pick v0.18.x |
|
@estroz: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/operator-framework/operator-sdk\n ! [rejected] cherry-pick-3221-to-v0.18.x -> cherry-pick-3221-to-v0.18.x (non-fast-forward)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:CENSORED@github.com/operator-framework/operator-sdk'\nhint: Updates were rejected because the tip of your current branch is behind\nhint: its remote counterpart. Integrate the remote changes (e.g.\nhint: 'git pull ...') before pushing again.\nhint: See the 'Note about fast-forwards' in 'git push --help' for details.\n", error: exit status 1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This version of operator-registry contains a fix for a bug that causes validation errors when an existing `annotations.yaml` does not exactly match the default annotations generated by `operator-sdk bundle create`. deps: bump operator-registry cmd/operator-sdk/bundle,internal/scorecard/alpha/tests: the `NewImageValidator` API changed such that the command must create an image registry first before creating a validator.
This version of operator-registry contains a fix for a bug that causes validation errors when an existing `annotations.yaml` does not exactly match the default annotations generated by `operator-sdk bundle create`. deps: bump operator-registry cmd/operator-sdk/bundle,internal/scorecard/alpha/tests: the `NewImageValidator` API changed such that the command must create an image registry first before creating a validator.
Description of the change:
Motivation for the change: This version of operator-registry contains a fix for a bug that causes validation errors when an existing
annotations.yamldoes not exactly match the default annotations generated byoperator-sdk bundle create./cc @camilamacedo86 @jmrodri @hasbro17 @varshaprasad96
/kind bug