bundle validate: add tool-less image validation #3222
Conversation
openshift-ci-robot
requested review from
hasbro17,
jmccormick2001 and
joelanford
openshift-ci-robot
added
the
kind/feature
| "One of: [docker, podman]") | ||
| "Tool to pull and unpack bundle images. Only used when validating a bundle image. "+ | ||
| "One of: [docker, podman, none]") | ||
|
|
||
| fs.StringVarP(&c.outputFormat, "output", "o", internal.Text, |
There was a problem hiding this comment.
when we call the bundle validation with the --image-builder and then bundle is in the disk (created with the generated-only) it is not WARNING that the value will be ignored or raising and error telling that the flag is invalid. Could we add that?
There was a problem hiding this comment.
We should either fail if that flag is set or do nothing, but that's something to do in a follow-up.
| "Tool to pull and unpack bundle images. Only used when validating a bundle image. "+ | ||
| "One of: [docker, podman, none]") |
There was a problem hiding this comment.
IMO we need to make clear that it is not a valid option when the bundle was created with the flag --generate-only . We know that when this flag is used an image is not created and in this way, it is not valid forOnly used when validating a bundle image.
However, we can make the info more implicit and directly instead of assuming that they will come this conclusion easily.
| "Tool to pull and unpack bundle images. Only used when validating a bundle image. "+ | |
| "One of: [docker, podman, none]") | |
| "Tool to pull and unpack bundle images. Bundles created with --generate-only has not images and this option is just useful with bundle images. "+ | |
| "One of: [docker, podman, none]") |
There was a problem hiding this comment.
I think the original is more clear, especially considering that this command can be used with non-SDK-generated bundles.
There was a problem hiding this comment.
IMO we need to make clear that it is not valid for the bundle created with the flag --generate-only explicitly, however, I am ok with any rephrase to address that.
| @@ -56,7 +56,7 @@ To build and validate an image: | |||
|
|
|||
| ``` | |||
| -h, --help help for validate | |||
| -b, --image-builder string Tool to extract bundle image data. Only used when validating a bundle image. One of: [docker, podman] (default "docker") | |||
| -b, --image-builder string Tool to pull and unpack bundle images. Only used when validating a bundle image. One of: [docker, podman, none] (default "docker") | |||
There was a problem hiding this comment.
I can use podman or docker to validate the image .. however, to create a can just use docker. Should we not be a valid option to create the bundle as well?
There was a problem hiding this comment.
You can use docker, podman, or buildah to create the bundle image (see help text of bundle create). I think the --image-builder name is confusing and should be changed to --container-tool or something. Needs a follow-up.
There was a problem hiding this comment.
I liked --container-tool
estroz
force-pushed
the
feature/bundle-validate-none-tool
branch
from
07d4336
to
a3acb91
Compare
images, removing the need for an external image tool like docker/podman. `bundle validate` should have this functionality. cmd/operator-sdk/bundle/validate.go: add "none" option to available image builder tools
estroz
force-pushed
the
feature/bundle-validate-none-tool
branch
from
a3acb91
to
ee8ac5a
Compare
Description of the change:
Motivation for the change:
ImageValidatorcan now use a containerd image ("none") tool to unpack images, removing the need for an external image tool like docker/podman./cc @hasbro17 @jmccormick2001 @joelanford
Blocked by #3221/kind feature