New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: new community validator to check bundles #4939
Merged
camilamacedo86
merged 1 commit into
operator-framework:master
from
camilamacedo86:community-validator
May 26, 2021
Merged
add: new community validator to check bundles #4939
camilamacedo86
merged 1 commit into
operator-framework:master
from
camilamacedo86:community-validator
May 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
May 23, 2021
camilamacedo86
force-pushed
the
community-validator
branch
from
May 23, 2021 18:54
c1fcf52
to
e244b2a
Compare
camilamacedo86
force-pushed
the
community-validator
branch
from
May 24, 2021 09:23
e244b2a
to
9a4f9b2
Compare
camilamacedo86
force-pushed
the
community-validator
branch
3 times, most recently
from
May 26, 2021 15:36
6030357
to
5767bab
Compare
camilamacedo86
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
May 26, 2021
jmrodri
approved these changes
May 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
camilamacedo86
force-pushed
the
community-validator
branch
from
May 26, 2021 15:54
5767bab
to
cbd1aed
Compare
Signed-off-by: Camila Macedo <cmacedo@redhat.com>
camilamacedo86
force-pushed
the
community-validator
branch
from
May 26, 2021 16:44
cbd1aed
to
e215135
Compare
/lgtm |
estroz
reviewed
May 26, 2021
|
||
(stage: alpha) To validate a bundle against the validator for Community Operators specifically, in addition to required bundle validators. This validator allows check the bundle image. In this way, inform the path-index optional key value: | ||
|
||
$ operator-sdk bundle validate ./bundle --select-optional name=community --optional-values=index-path=bundle.Dockerfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's with this index-path
keyword? It's pointing to a bundle dockerfile...
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new community-validator which implemented in the API (operator-framework/api#120)
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs
Note