Skip to content

additionals and improvements to dealing with deprecated API(s) #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2021
Merged

additionals and improvements to dealing with deprecated API(s) #120

merged 1 commit into from
May 26, 2021

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented May 23, 2021 •
edited
Loading

Description

Check the new optional validator called via SDK

Screen Shot 2021-05-23 at 19 39 28

Also, check its CLI helpers

Screen Shot 2021-05-23 at 19 41 15

Screen Shot 2021-05-23 at 19 40 44

Related PRs

@openshift-ci openshift-ci bot requested review from joelanford and timflannagan May 23, 2021 18:00
@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented May 23, 2021 •
edited
Loading

/assign @ecordell
/assign @kevinrizza
/assign @njhale

This was referenced May 23, 2021
Merged
Merged
jmrodri
jmrodri requested changes May 24, 2021
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error messages could use a little wording changes. The rest of the PR looks fine.

kevinrizza
kevinrizza requested changes May 24, 2021
View reviewed changes
Copy link
Member

@kevinrizza kevinrizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also worth keeping in mind that we are going to completely remove support from these API versions very soon, so writing warnings about these resource types needs to happen soon if we want to cut a release before a bump to Kubernetes 1.22

@camilamacedo86 camilamacedo86 requested a review from jmrodri May 24, 2021 23:03
@camilamacedo86 camilamacedo86 changed the title add community validator additionals and improvements to dealing with deprecated API(s) May 25, 2021
@camilamacedo86 camilamacedo86 requested a review from kevinrizza May 25, 2021 11:18
@kevinrizza
Copy link
Member

/approve

@openshift-ci
Copy link

openshift-ci bot commented May 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2021
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2021
@camilamacedo86
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2021
@camilamacedo86
additionals and improvements to dealing with deprecated API(s)
2c20e68 
- add new validator ( Community Operator )
- improve the operatorhub.io validator to check the possible deprecated apis kinds mapped on the project
@kevinrizza
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2021
@openshift-merge-robot openshift-merge-robot merged commit b9384fb into operator-framework:master May 26, 2021
@camilamacedo86 camilamacedo86 deleted the community-opertor branch May 26, 2021 14:46
@camilamacedo86 camilamacedo86 mentioned this pull request Sep 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@timflannagan timflannagan Awaiting requested review from timflannagan

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@ecordell ecordell

@kevinrizza kevinrizza

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@camilamacedo86 @kevinrizza @jmrodri @ecordell @openshift-merge-robot