Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

Add some info & pointers to <noscript> fallback #81

Merged
merged 2 commits into from
Mar 12, 2019

Conversation

cben
Copy link
Contributor

@cben cben commented Mar 7, 2019

Inspired by a post on operator-framework mailing list.
Goals: add minimal info that might make people surfing without JavaScript happier:

  • point to underlying data on github, one could clone and browse it directly without this app.
  • point to this repo with source — some people only object to running proprietary JS.
  • sort-of replace https://www.operatorhub.io/what-is-an-operator and https://www.operatorhub.io/contribute (which also don't work without JS) — the community-operators repo explains these
    • GitHub itself is reasonably surfable without JS — not everything works but you can see the README and learn how to git clone it.
  • doesn't replace https://www.operatorhub.io/about (which also doesn't work without JS), but I guess if you can't run the app you don't care ;-)

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 7, 2019
@cben
Copy link
Contributor Author

cben commented Mar 7, 2019

recording of viewing this (and following the github links) in links 👩‍💻 :

retro.svg

and for more nostalgia ⏳ (mosaic fails to load github though):

captura de pantalla de 2019-03-07 13-08-17

@jeff-phillips-18
Copy link
Contributor

@cben Thanks for this. Could you add the following to app.scss just to layout the text a bit better:

noscript {
  margin: 20px 40px;
  h1 {
    text-align: center;
  }
  p {
    padding: 0 30px;
  }
}

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2019
@cben
Copy link
Contributor Author

cben commented Mar 10, 2019

Done.
OperatorHub io   The registry for Kubernetes Operators

@jeff-phillips-18 jeff-phillips-18 merged commit d706bab into operator-framework:master Mar 12, 2019
J0zi pushed a commit that referenced this pull request Oct 15, 2019
- Operator was accidentally merged while WIP
- Future PR will add the updated operator

In favor of #81
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants