Improve secret management #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exclude memcache and Postgres secret var
…m .Values.environment to a separate secret
…onment is non-empty
…ironment, as those now live in a separate secret
…dc.enabled is true
…d in a separate secret
… used (.Values.openproject.cache.store equals memcache)
…th the postgresql chart
…TABASE_URL, needs to be set in another environment variable from e.g. the existing secret
… or from .Values.postgresql.auth.password
…handling' into secrets
🦋 Changeset detectedLatest commit: 33c7ab0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
oliverguenther
approved these changes
Dec 13, 2023
This was referenced Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes the changes from #8 and #20, adapts them and unifies them.
Thanks to @johanneskastl and @pitwegner for the PRs!
In the course of this process the following changes were made as well.
existingSecretoption for S3 credentials (secret access key and access key id)s3.accessKeyIdands3.secretAccessKeyIdtos3.auth.accessKeyIdands3.auth.secretAccessKeyMoreover, installations or upgrades will fail if no postgres password is provided.
Important
For this to work it needs the latest OpenProject 13.1 images (to be released tomorrow, 13th Dec 2023).
For the released images to work correctly, the database.yml bug has to be fixed as well. Working on that. Until this is released the test will fail with the following.
So this PR will only go green once 13.1 is released including that bug fix which is when this will be merged.