-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve secret management #46
Conversation
exclude memcache and Postgres secret var
…m .Values.environment to a separate secret
…onment is non-empty
…ironment, as those now live in a separate secret
…dc.enabled is true
…d in a separate secret
… used (.Values.openproject.cache.store equals memcache)
…th the postgresql chart
…TABASE_URL, needs to be set in another environment variable from e.g. the existing secret
… or from .Values.postgresql.auth.password
…handling' into secrets
🦋 Changeset detectedLatest commit: 33c7ab0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thank you for consolidating the two issues 💙
Takes the changes from #8 and #20, adapts them and unifies them.
Thanks to @johanneskastl and @pitwegner for the PRs!
In the course of this process the following changes were made as well.
existingSecret
option for S3 credentials (secret access key and access key id)s3.accessKeyId
ands3.secretAccessKeyId
tos3.auth.accessKeyId
ands3.auth.secretAccessKey
Moreover, installations or upgrades will fail if no postgres password is provided.
Important
For this to work it needs the latest OpenProject 13.1 images (to be released tomorrow, 13th Dec 2023).
For the released images to work correctly, the database.yml bug has to be fixed as well. Working on that. Until this is released the test will fail with the following.
So this PR will only go green once 13.1 is released including that bug fix which is when this will be merged.