Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate with file storages such as Nextcloud #10052

Merged
merged 158 commits into from
Mar 28, 2022
Merged

Integrate with file storages such as Nextcloud #10052

merged 158 commits into from
Mar 28, 2022

Conversation

wielinde
Copy link
Member

@wielinde wielinde commented Jan 14, 2022 •
edited by cbliard
Loading

https://community.openproject.org/work_packages/40203

TODO:

  • Create admin interface for adding file storages and create interface for adding storages to projects, including the necessary privileges.
    • Basic CRUD
    • Move business logic from controllers to services and contracts (Frank)
    • Cover validation errors etc in controllers (Wieland)
    • Specs
      • Feature specs:
        • happy path CRUD Storage records
        • happy path CD ProjectStorage records
      • Models
        • Storage
        • ProjectStorage
        • FileLink
      • Controller
        • Storages
        • ProjectsStorages
      • Services and contracts
        • Storage
        • ProjectStorage (Frank)
          • Cover all validations in contract specs (Frank)
          • Cover that errors a displayed to the user (Frank)
        • FileLink
          • Cover all validations in contract specs
  • [#40228] API to CRUD links between files (i.e. Nextcloud) and work packages in OpenProject https://community.openproject.org/work_packages/40228
  • work off ToDos (today)
  • squash branch before merging into dev into a more readable history (decide, if a rebase is needed).
    • please, do not squash, it makes git history unreadable and commit messages useless. I'd prefer a merge commit. We could also rebase but it makes references to commits stale. (Christophe)

@wielinde wielinde marked this pull request as draft January 14, 2022 16:25
@wielinde wielinde force-pushed the feature/file-links branch 2 times, most recently from 7abd016 to c8ef199 Compare January 26, 2022 12:23
@wielinde wielinde force-pushed the feature/file-links branch 2 times, most recently from 91f6ea1 to 21ae30a Compare January 31, 2022 08:49
wielinde and others added 13 commits January 31, 2022 17:13
@wielinde
Integrate with file storages such as Nextcloud
cf73043 
https://community.openproject.org/work_packages/40203

TODO:
- [ ] Create admin interface for adding file storages
- [ ] Create
- [ ] [#40228] API to CRUD links between files (i.e. Nextcloud) and work packages in OpenProject https://community.openproject.org/work_packages/40228
@wielinde
Fix errors in FileLink model.
b8f185e
@wielinde
WIP project settings for storages
a3e0231
@Kharonus @wielinde
[#40228] added API skeleton
819055d
@Kharonus @wielinde
[#40228] added API skeleton
3cb5973
@wielinde
Improve migration for file links
8c1895e
@wielinde
Fix migration and model for storages
48e9b12
@wielinde
Fix migration and model for ProjectStorage
cf99edc
@Kharonus @wielinde
[#40228] added storages endpoint
f890926 
- fixed request test for DELETE
- added request test for storages endpoint
@wielinde
Several improvements for the storages administration
56aa457
@wielinde
Fix settings menu and edge cases
c623188
@wielinde
On removing a storage from a project remove all file links to WPs in …
2732b19 
…that project
@wielinde
Adding host to storages. And adding more specs
2b2cc24
Kharonus and others added 5 commits February 2, 2022 11:01
@Kharonus
[#40228] implement get file link endpoint
3495ae9 
- added implementation for get storage by id
- amended request tests
- added test factories
- added permissions for storages
@Kharonus
[40228] added permission check for file links
b5ce5bf
@cbliard
make rubocop happier
a16d1cd
@cbliard
fix test
a6a0e1e
@Kharonus
[#40228] added get file link collection endpoint
0e7bc8b
@SwikritiT SwikritiT mentioned this pull request Mar 24, 2022
Merged
@cbliard cbliard marked this pull request as ready for review March 24, 2022 15:52
@cbliard
Copy link
Member

cbliard commented Mar 24, 2022

One thing left: add some logs when connection to storage server fails because it can be a user issue and ops will need more information to assist user.

ulferts
ulferts approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@ulferts ulferts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the work, @cbliard, @Kharonus, @fraber and @wielinde 👍 🚀

@cbliard cbliard merged commit 73b840b into dev Mar 28, 2022
@cbliard cbliard deleted the feature/file-links branch March 28, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbliard cbliard cbliard left review comments

@ulferts ulferts ulferts approved these changes

@Kharonus Kharonus Kharonus left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
5 participants
@wielinde @cbliard @ulferts @Kharonus @fraber